From 56f259f61a2bb96a7a956dee1a69ebcd242c454f Mon Sep 17 00:00:00 2001
From: Melledy <121644117+Melledy@users.noreply.github.com>
Date: Wed, 19 Jun 2024 13:46:11 -0700
Subject: [PATCH] Fix equipping items on the trailblazer

---
 src/main/java/emu/lunarcore/game/avatar/AvatarStorage.java | 5 +++++
 src/main/java/emu/lunarcore/game/inventory/GameItem.java   | 4 ++--
 src/main/java/emu/lunarcore/game/inventory/Inventory.java  | 2 +-
 src/main/java/emu/lunarcore/game/player/Player.java        | 5 -----
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/main/java/emu/lunarcore/game/avatar/AvatarStorage.java b/src/main/java/emu/lunarcore/game/avatar/AvatarStorage.java
index ff6a6c3..cf59db0 100644
--- a/src/main/java/emu/lunarcore/game/avatar/AvatarStorage.java
+++ b/src/main/java/emu/lunarcore/game/avatar/AvatarStorage.java
@@ -40,6 +40,11 @@ public class AvatarStorage extends BasePlayerManager implements Iterable<GameAva
     }
 
     public GameAvatar getAvatarById(int id) {
+        // Check if we are trying to retrieve the hero character
+        if (GameData.getHeroExcelMap().containsKey(id)) {
+            id = GameConstants.TRAILBLAZER_AVATAR_ID;
+        }
+        
         return getAvatars().get(id);
     }
     
diff --git a/src/main/java/emu/lunarcore/game/inventory/GameItem.java b/src/main/java/emu/lunarcore/game/inventory/GameItem.java
index 5e22ee9..7adef28 100644
--- a/src/main/java/emu/lunarcore/game/inventory/GameItem.java
+++ b/src/main/java/emu/lunarcore/game/inventory/GameItem.java
@@ -293,7 +293,7 @@ public class GameItem {
                 .setMainAffixId(this.mainAffix);
         
         if (this.getEquipAvatar() != null) {
-            proto.setEquipAvatarId(this.getEquipAvatar().getAvatarId());
+            proto.setEquipAvatarId(this.getEquipAvatar().getExcel().getId());
         }
 
         if (this.subAffixes != null) {
@@ -316,7 +316,7 @@ public class GameItem {
                 .setRank(this.getRank());
         
         if (this.getEquipAvatar() != null) {
-            proto.setEquipAvatarId(this.getEquipAvatar().getAvatarId());
+            proto.setEquipAvatarId(this.getEquipAvatar().getExcel().getId());
         }
         
         return proto;
diff --git a/src/main/java/emu/lunarcore/game/inventory/Inventory.java b/src/main/java/emu/lunarcore/game/inventory/Inventory.java
index c2cc20c..38728ef 100644
--- a/src/main/java/emu/lunarcore/game/inventory/Inventory.java
+++ b/src/main/java/emu/lunarcore/game/inventory/Inventory.java
@@ -564,7 +564,7 @@ public class Inventory extends BasePlayerManager {
     }
 
     public boolean unequipItem(int avatarId, int slot) {
-        GameAvatar avatar = getPlayer().getAvatars().getAvatarById(avatarId);
+        GameAvatar avatar = getPlayer().getAvatarById(avatarId);
 
         if (avatar != null) {
             GameItem unequipped = avatar.unequipItem(slot);
diff --git a/src/main/java/emu/lunarcore/game/player/Player.java b/src/main/java/emu/lunarcore/game/player/Player.java
index 49e35db..a8d08ee 100644
--- a/src/main/java/emu/lunarcore/game/player/Player.java
+++ b/src/main/java/emu/lunarcore/game/player/Player.java
@@ -328,11 +328,6 @@ public class Player implements Tickable {
     }
 
     public GameAvatar getAvatarById(int avatarId) {
-        // Check if we are trying to retrieve the hero character
-        if (GameData.getHeroExcelMap().containsKey(avatarId)) {
-            avatarId = GameConstants.TRAILBLAZER_AVATAR_ID;
-        }
-        
         return getAvatars().getAvatarById(avatarId);
     }