stringstack patches

Erupe/common/stringstack/stringstack.go

@@ -2,33 +2,45 @@ package stringstack
 
 import (
 	"errors"
-	"sync"
 )
 
 // StringStack is a basic LIFO "stack" for storing strings.
 type StringStack struct {
-	sync.Mutex
+	Locked bool
-	stack []string
+	stack  []string
 }
 
 // New creates a new instance of StringStack
 func New() *StringStack {
-	return &StringStack{}
+	return &StringStack{Locked: false}
+}
+
+// Set sets up a new StringStack
+func (s *StringStack) Set(v string) {
+	s.stack = []string{v}
+}
+
+// Lock freezes the StringStack
+func (s *StringStack) Lock() {
+	if !s.Locked {
+		s.Locked = true
+	}
+}
+
+// Unlock unfreezes the StringStack
+func (s *StringStack) Unlock() {
+	if s.Locked {
+		s.Locked = false
+	}
 }
 
 // Push pushes a string onto the stack.
 func (s *StringStack) Push(v string) {
-	s.Lock()
-	defer s.Unlock()
-
 	s.stack = append(s.stack, v)
 }
 
 // Pop pops a string from the stack.
 func (s *StringStack) Pop() (string, error) {
-	s.Lock()
-	defer s.Unlock()
-
 	if len(s.stack) == 0 {
 		return "", errors.New("no items on stack")
 	}

Erupe/server/channelserver/handlers_stage.go

@@ -120,10 +120,14 @@ func removeSessionFromStage(s *Session) {
 
 func handleMsgSysEnterStage(s *Session, p mhfpacket.MHFPacket) {
 	pkt := p.(*mhfpacket.MsgSysEnterStage)
+
 	// Push our current stage ID to the movement stack before entering another one.
-	s.Lock()
+	if s.stageID == "" {
-	s.stageMoveStack.Push(s.stageID)
+		s.stageMoveStack.Set(pkt.StageID)
-	s.Unlock()
+	} else {
+		s.stageMoveStack.Push(s.stageID)
+		s.stageMoveStack.Lock()
+	}
 
 	s.QueueSendMHF(&mhfpacket.MsgSysCleanupObject{})
 	if s.reservationStage != nil {
@@ -137,9 +141,8 @@ func handleMsgSysBackStage(s *Session, p mhfpacket.MHFPacket) {
 	pkt := p.(*mhfpacket.MsgSysBackStage)
 
 	// Transfer back to the saved stage ID before the previous move or enter.
-	s.Lock()
+	s.stageMoveStack.Unlock()
 	backStage, err := s.stageMoveStack.Pop()
-	s.Unlock()
 
 	if err != nil {
 		panic(err)
@@ -151,10 +154,10 @@ func handleMsgSysBackStage(s *Session, p mhfpacket.MHFPacket) {
 func handleMsgSysMoveStage(s *Session, p mhfpacket.MHFPacket) {
 	pkt := p.(*mhfpacket.MsgSysMoveStage)
 
-	// Push our current stage ID to the movement stack before entering another one.
+	// Set a new move stack from the given stage ID if unlocked
-	s.Lock()
+	if !s.stageMoveStack.Locked {
-	s.stageMoveStack.Push(s.stageID)
+		s.stageMoveStack.Set(pkt.StageID)
-	s.Unlock()
+	}
 
 	doStageTransfer(s, pkt.AckHandle, pkt.StageID)
 }