Mirror/Erupe
1
0
Fork 0
mirror of https://github.com/Mezeporta/Erupe.git synced 2026-03-21 23:22:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf(channelserver): use package-level map for ignored opcodes

Browse Source 
The ignored() function is called on every packet when debug logging
is enabled. It was rebuilding a slice and map from scratch each time.
Move to a package-level map initialized once at startup.
This commit is contained in:
Houmgaor
2026-02-21 13:42:33 +01:00
parent c04fa504cc
commit 9da467e00f
1 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
server/channelserver/sys_session.go
View File

@@ -279,22 +279,18 @@ func (s *Session) handlePacketGroup(pktGroup []byte) {
}
}
var ignoredOpcodes = map[network.PacketID]struct{}{
network.MSG_SYS_END: {},
network.MSG_SYS_PING: {},
network.MSG_SYS_NOP: {},
network.MSG_SYS_TIME: {},
network.MSG_SYS_EXTEND_THRESHOLD: {},
network.MSG_SYS_POSITION_OBJECT: {},
}
func ignored(opcode network.PacketID) bool {
ignoreList := []network.PacketID{
network.MSG_SYS_END,
network.MSG_SYS_PING,
network.MSG_SYS_NOP,
network.MSG_SYS_TIME,
network.MSG_SYS_EXTEND_THRESHOLD,
network.MSG_SYS_POSITION_OBJECT,
// network.MSG_MHF_SAVEDATA, // Temporarily enabled for debugging save issues
}
set := make(map[network.PacketID]struct{}, len(ignoreList))
for _, s := range ignoreList {
set[s] = struct{}{}
}
_, r := set[opcode]
return r
_, ok := ignoredOpcodes[opcode]
return ok
}
func (s *Session) logMessage(opcode uint16, data []byte, sender string, recipient string) {