Commit Graph

37 Commits

Author SHA1 Message Date
Houmgaor
c64dabc3ba fix: check all Close() return values for errcheck lint
Add explicit error discards (_ =) for Close() calls on network
connections, SQL rows, and file handles across 28 files. Also add
.golangci.yml with standard linter defaults to match CI configuration.
2026-02-17 23:57:14 +01:00
Houmgaor
47f7a1f636 fix(channelserver): handle bare Exec errors and filter expected ErrNoRows
138 bare db.Exec calls across 22 handler files silently dropped write
errors. Each is now wrapped with error check and zap logging.

4 QueryRow sites that legitimately return sql.ErrNoRows during normal
operation (new player mezfes, festa rankings, empty guild item box)
now filter it out to reduce log noise.
2026-02-17 23:33:44 +01:00
Houmgaor
46bbb6adf9 fix: resolve all remaining lint errors (errcheck) across 49 files
Fix unchecked error returns on bf.Seek(), db.Exec(), QueryRow().Scan(),
pkt.Build(), logger.Sync(), and binary.Write() calls. The linter now
passes with 0 errors, build compiles, and all tests pass with -race.
2026-02-17 18:07:38 +01:00
Houmgaor
2a0e3e2c84 fix: re-enable CI lint job and fix ~65 lint errors (partial)
Re-enable the golangci-lint job in CI (disabled Oct 2025), update to
Go 1.25 and golangci-lint-action v7. Fix errcheck, gosimple S1009,
staticcheck SA4031 and SA2001 errors across 54 files. Remaining ~39
lint errors will be addressed in follow-up commits.
2026-02-17 17:59:00 +01:00
Houmgaor
fb3e86f429 fix: handle Query/QueryRow/transaction errors in channel server handlers
Add error checking and logging for ~25 database call sites that were
silently dropping errors, preventing resource leaks (unclosed rows),
nil pointer panics, and silent data corruption in festa transactions.
2026-02-17 17:44:35 +01:00
wish
8a55c5ff89 fix inflated festa rewards 2024-09-27 01:12:16 +10:00
wish
a9b9c94347 fix RNG 2024-02-21 03:46:15 +11:00
wish
d0e727d444 fix remaining Festa queries 2024-02-20 18:52:56 +11:00
wish
c3409996ef rollback unknown Festa values 2024-02-20 15:02:10 +11:00
wish
5bcfe25ede implement Festa Bonus Categories & Guild Character optimisations 2024-02-20 04:18:16 +11:00
wish
d22a7c782f changes to FestivalColor 2024-02-20 04:16:26 +11:00
wish
1c4370b929 fix EnumerateFestaMember prior to Z2 2024-02-20 04:12:22 +11:00
wish
9cfbd92454 add blank Winner entries to InfoFesta 2024-02-19 18:36:03 +11:00
wish
183f88654b fix InfoFesta response on S6.0 2024-02-19 18:12:51 +11:00
wish
18cabd03f1 add version case to FestaInfo 2024-02-19 17:32:32 +11:00
wish
32dee9039e simplify config 2023-12-31 12:54:18 +11:00
wish
0ea0dc217b simplify config 2023-12-31 12:51:24 +11:00
wish
0069a5029f decode Festa stuff 2023-12-31 11:42:44 +11:00
wish
5a6ced5a41 document unknown Festa values 2023-11-22 21:19:07 +11:00
wish
1e6675b3f5 add support for Festa Trial voting 2023-11-19 04:59:30 +11:00
wish
2539afb5d3 simplify Festa reward data 2023-10-02 00:45:28 +11:00
Samboge
2027238250 Fix for Festa Rewards and House Visit MHF-F5
Partial Fix for Forward 5
2023-09-27 07:12:27 +07:00
wish
b69b396978 fix maximum FP data size in response 2023-08-17 22:15:36 +10:00
wish
769f989c91 add MaximumFP option, hide null Festa Armor 2023-07-22 23:12:26 +10:00
wish
e6393d73dc fix and structise InfoFesta 2023-07-22 21:11:53 +10:00
wish
ccfd2ac36f create RNG in token module 2023-03-12 23:29:50 +11:00
wish
e811dd1274 initial time fix 2023-03-04 21:43:10 +11:00
wish
42ab117c7f fix mezfes data saving 2023-02-28 23:15:21 +11:00
wish
a71ad2aa3e fix festa prize enumeration 2022-10-23 18:50:48 +11:00
wish
cfb2dff9c3 sort festa members by soul count 2022-10-23 18:46:41 +11:00
wish
c6c247b56b better festa responses 2022-10-17 13:41:30 +11:00
wish
f80a807fb1 fix unneeded enumerations 2022-08-26 16:08:51 +10:00
wish
951c8e9c21 correct some festa functions 2022-08-26 15:46:31 +10:00
wish
f6148271ea simplify guild code 2022-08-23 09:26:09 +10:00
wish
b093d98d01 decode tournament info 2022-08-13 02:08:26 +10:00
wish
8350273ab1 merge changes 2022-08-03 17:14:46 +10:00
wish
2c0e7a5267 repository cleanup 2022-07-29 03:25:23 +10:00