Houmgaor
35665a46d8
refactor(channelserver): split handlers_guild.go into sub-files
...
handlers_guild.go was 2090 lines mixing unrelated guild subsystems.
Extract handlers into focused files following the existing pattern:
- handlers_guild_ops.go: OperateGuild switch + member operations
- handlers_guild_info.go: InfoGuild + EnumerateGuild display
- handlers_guild_mission.go: guild mission system
- handlers_guild_cooking.go: meals, weekly bonus, hunt data
- handlers_guild_board.go: message board system
Core types, methods, and DB functions remain in handlers_guild.go
(now ~1000 lines).
2026-02-18 00:19:11 +01:00
Houmgaor
c64dabc3ba
fix: check all Close() return values for errcheck lint
...
Add explicit error discards (_ =) for Close() calls on network
connections, SQL rows, and file handles across 28 files. Also add
.golangci.yml with standard linter defaults to match CI configuration.
2026-02-17 23:57:14 +01:00
Houmgaor
47f7a1f636
fix(channelserver): handle bare Exec errors and filter expected ErrNoRows
...
138 bare db.Exec calls across 22 handler files silently dropped write
errors. Each is now wrapped with error check and zap logging.
4 QueryRow sites that legitimately return sql.ErrNoRows during normal
operation (new player mezfes, festa rankings, empty guild item box)
now filter it out to reduce log noise.
2026-02-17 23:33:44 +01:00
Houmgaor
88fc17e790
fix: purge excess guild posts and clarify alliance TODO
...
Purge oldest guild posts beyond the limit (100 messages, 4 news) after
each new post is created. Replace misleading alliance application TODO
with a note that the feature is not yet implemented.
2026-02-17 18:12:07 +01:00
Houmgaor
46bbb6adf9
fix: resolve all remaining lint errors (errcheck) across 49 files
...
Fix unchecked error returns on bf.Seek(), db.Exec(), QueryRow().Scan(),
pkt.Build(), logger.Sync(), and binary.Write() calls. The linter now
passes with 0 errors, build compiles, and all tests pass with -race.
2026-02-17 18:07:38 +01:00
Houmgaor
2a0e3e2c84
fix: re-enable CI lint job and fix ~65 lint errors (partial)
...
Re-enable the golangci-lint job in CI (disabled Oct 2025), update to
Go 1.25 and golangci-lint-action v7. Fix errcheck, gosimple S1009,
staticcheck SA4031 and SA2001 errors across 54 files. Remaining ~39
lint errors will be addressed in follow-up commits.
2026-02-17 17:59:00 +01:00
Houmgaor
fb3e86f429
fix: handle Query/QueryRow/transaction errors in channel server handlers
...
Add error checking and logging for ~25 database call sites that were
silently dropping errors, preventing resource leaks (unclosed rows),
nil pointer panics, and silent data corruption in festa transactions.
2026-02-17 17:44:35 +01:00
Houmgaor
c55f23442b
fix(lint): fixing go static check failing.
2025-10-19 22:52:58 +02:00
Houmgaor
fc6e479df9
fix(lint): fixing more complex formatters problems.
2025-10-19 22:46:21 +02:00
Houmgaor
1398383a8d
fix(lint): automated linting, with simple formatter.
2025-10-19 22:43:05 +02:00
wish
531b3d2fa6
Remove unused import 'math' from handlers_guild.go
...
Removed unused 'math' import from handlers_guild.go
2025-08-29 22:56:46 +10:00
wish
7459dede49
fix guild poogie outfit unlock
2025-08-28 23:27:56 +10:00
wish
8c219be30f
fix InfoGuild response on <G10
2025-03-10 11:38:00 +11:00
wish
3e71c308f4
minor MhfInfoGuild changes
2025-03-06 23:01:22 +11:00
wish
5028355cfc
prevent nil pointer in MhfGetGuildManageRight
2025-02-23 21:46:00 +11:00
wish
846f8d6693
retain excess Room RP
2024-02-28 21:24:55 +11:00
wish
e5703617bb
add support for Clan Changing Room
2024-02-28 19:29:06 +11:00
wish
f5c772413e
rename instances of HRP to HR
2024-02-25 22:20:12 +11:00
wish
c74ce4b07f
simplify reused code
2024-02-25 14:22:21 +11:00
wish
40d4aba3c4
convert other Warehouse types to new system
2024-02-25 14:12:37 +11:00
wish
d0e727d444
fix remaining Festa queries
2024-02-20 18:52:56 +11:00
wish
d22a7c782f
changes to FestivalColor
2024-02-20 04:16:26 +11:00
wish
52082aaf06
use correct GuildMember length
2023-12-31 11:43:10 +11:00
wish
3d08e64b07
add comments
2023-12-02 21:18:16 +11:00
wish
4bae0e5758
add option to alter maximum Clan Members
2023-11-30 23:07:13 +11:00
wish
b3af01b803
use seconds for arbitrary durations in config
2023-11-26 18:54:04 +11:00
wish
1e6675b3f5
add support for Festa Trial voting
2023-11-19 04:59:30 +11:00
wish
85fc76edd5
update parsing of many packets
2023-11-19 02:34:02 +11:00
wish
fc57d63689
update parsing of many packets
2023-11-19 00:35:22 +11:00
wish
6f99698525
fix indentation
2023-10-08 20:37:04 +11:00
wish
641032f862
implement hunt data logging (partial #82 )
2023-10-08 19:25:48 +11:00
wish
f37915bcae
simplify Guild Huntdata & decimal conversions
2023-10-07 19:59:37 +11:00
wish
8e27617727
convert Guild Missions to struct
2023-10-07 19:58:49 +11:00
wish
aad9425a73
guess Forward.5 compatibility
2023-07-22 18:22:21 +10:00
wish
dbedab4d33
add ClientMode support based on Forward.4
2023-07-22 16:47:44 +10:00
wish
0b4dca5c45
fix RP not being consistent between clients
2023-07-22 03:00:07 +10:00
wish
216893e3ce
InfoGuild decoding & GetGuildManageRight cleanup
2023-07-09 15:57:48 +10:00
wish
db6b7795c5
clean up OperateGuild
2023-07-08 22:41:57 +10:00
wish
a23e1b62a2
GetGuildInfo further decoding
2023-07-08 22:16:58 +10:00
wish
1f93419cb7
add support for more versions
2023-07-03 00:30:44 +10:00
wish
b4df642ee3
add ClientMode config option
2023-06-18 20:31:18 +10:00
wish
6fecfdd63f
rewrite EnumerateGuildMember
2023-04-23 21:48:13 +10:00
wish
e61d6a60f3
rewrite EnumerateGuild
2023-04-23 20:26:51 +10:00
wish
4ffb176049
prevent reading past message board packet
2023-04-10 18:52:12 +10:00
wish
107eddfea5
stub interception map packets
2023-03-27 21:29:23 +11:00
wish
cce558db9c
amend comment
2023-03-12 22:28:27 +11:00
wish
1f349a342e
add some gameplay options
2023-03-09 18:51:36 +11:00
wish
cd53f5f9db
prevent applicants from receiving message board notifications
2023-03-09 17:34:05 +11:00
wish
b3e4da2c73
simplify guild message board query
2023-03-04 23:49:42 +11:00
wish
ecb93dbc13
fix guild meal enumeration
2023-03-04 22:15:39 +11:00
