Houmgaor 458d8c9397 refactor(channelserver): add numeric column helpers and extract protocol constants ...

Add readCharacterInt/adjustCharacterInt helpers for single-column
integer operations on the characters table. Eliminates fmt.Sprintf
SQL construction in handlers_misc.go and replaces inline queries
across cafe, kouryou, and mercenary handlers.

Second round of protocol constant extraction: adds constants_time.go
(secsPerDay, secsPerWeek), constants_raviente.go (register IDs,
semaphore constants), and named constants across 14 handler files
replacing raw hex/numeric literals. Updates anti-patterns doc to
mark #4 (magic numbers) as substantially fixed.

2026-02-20 21:18:40 +01:00

..

compression

refactor: replace panic calls with structured error handling

2026-02-20 19:11:41 +01:00

channel_isolation_test.go

fix(channelserver): eliminate data races in shutdown and session lifecycle

2026-02-20 14:36:37 +01:00

channel_registry_local.go

feat(channelserver): decouple channel servers for independent operation (#33)

2026-02-19 18:13:34 +01:00

channel_registry_test.go

feat(channelserver): decouple channel servers for independent operation (#33)

2026-02-19 18:13:34 +01:00

channel_registry.go

feat(channelserver): decouple channel servers for independent operation (#33)

2026-02-19 18:13:34 +01:00

client_connection_simulation_test.go

…

constants_quest.go

refactor(channelserver): replace magic numbers with named protocol constants

2026-02-20 19:50:28 +01:00

constants_raviente.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

constants_time.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

doc.go

docs: add doc.go files and godoc comments to all packages

2026-02-18 21:39:13 +01:00

guild_model.go

refactor: replace panic calls with structured error handling

2026-02-20 19:11:41 +01:00

handlers_achievement_test.go

…

handlers_achievement.go

refactor(channelserver): migrate inline queries to helpers and define named constants

2026-02-20 19:46:57 +01:00

handlers_bbs_test.go

…

handlers_bbs.go

…

handlers_cafe_test.go

…

handlers_cafe.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_campaign_test.go

…

handlers_campaign.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_caravan_test.go

…

handlers_caravan.go

docs: add doc.go files and godoc comments to all packages

2026-02-18 21:39:13 +01:00

handlers_cast_binary_test.go

fix: re-enable CI lint job and fix ~65 lint errors (partial)

2026-02-17 17:59:00 +01:00

handlers_cast_binary.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_character_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_character.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_clients_test.go

fix: resolve 4 pre-existing test failures in channelserver

2026-02-18 15:59:36 +01:00

handlers_clients.go

fix(channelserver): handle bare Exec errors and filter expected ErrNoRows

2026-02-17 23:33:44 +01:00

handlers_commands.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_core_test.go

…

handlers_coverage2_test.go

refactor(mhfpacket): rename 15 Unk fields with identified meanings

2026-02-18 21:48:08 +01:00

handlers_coverage3_test.go

refactor(mhfpacket): rename 15 Unk fields with identified meanings

2026-02-18 21:48:08 +01:00

handlers_coverage4_test.go

refactor(mhfpacket): rename 15 Unk fields with identified meanings

2026-02-18 21:48:08 +01:00

handlers_coverage5_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_coverage_test.go

…

handlers_data_extended_test.go

fix: re-enable CI lint job and fix ~65 lint errors (partial)

2026-02-17 17:59:00 +01:00

handlers_data_paper_tables.go

refactor(channelserver): split handlers_data.go into sub-files

2026-02-18 00:47:14 +01:00

handlers_data_paper.go

refactor(mhfpacket): rename 15 Unk fields with identified meanings

2026-02-18 21:48:08 +01:00

handlers_data_test.go

fix: resolve 4 pre-existing test failures in channelserver

2026-02-18 15:59:36 +01:00

handlers_data.go

docs: mark binary I/O and copy-paste anti-patterns as resolved

2026-02-20 20:55:06 +01:00

handlers_discord_test.go

…

handlers_discord.go

fix: re-enable CI lint job and fix ~65 lint errors (partial)

2026-02-17 17:59:00 +01:00

handlers_distitem.go

fix(channelserver): handle ignored DB errors and cache userID on session

2026-02-20 21:06:16 +01:00

handlers_diva_test.go

…

handlers_diva.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_event_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_event.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_festa_test.go

…

handlers_festa.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_gacha.go

fix(channelserver): handle ignored DB errors and cache userID on session

2026-02-20 21:06:16 +01:00

handlers_goocoo.go

fix(channelserver): validate packet fields before use in handlers

2026-02-19 00:23:04 +01:00

handlers_guild_adventure.go

docs: add doc.go files and godoc comments to all packages

2026-02-18 21:39:13 +01:00

handlers_guild_alliance.go

refactor: replace panic calls with structured error handling

2026-02-20 19:11:41 +01:00

handlers_guild_board.go

Merge pull request #154 from Mezeporta/fix/guild-posts-soft-delete

2026-02-20 19:13:54 +01:00

handlers_guild_cooking.go

fix(channelserver): handle ignored DB errors and cache userID on session

2026-02-20 21:06:16 +01:00

handlers_guild_icon_test.go

…

handlers_guild_info.go

refactor(channelserver): replace magic numbers with named protocol constants

2026-02-20 19:50:28 +01:00

handlers_guild_member_test.go

…

handlers_guild_member.go

docs: add doc.go files and godoc comments to all packages

2026-02-18 21:39:13 +01:00

handlers_guild_mission.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_guild_ops.go

refactor: replace panic calls with structured error handling

2026-02-20 19:11:41 +01:00

handlers_guild_scout.go

refactor: replace panic calls with structured error handling

2026-02-20 19:11:41 +01:00

handlers_guild_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_guild_tresure.go

docs: add doc.go files and godoc comments to all packages

2026-02-18 21:39:13 +01:00

handlers_guild.go

fix(channelserver): add fail ACKs to silent error paths to prevent client softlocks

2026-02-20 19:35:25 +01:00

handlers_helpers.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_house_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_house.go

fix(channelserver): handle ignored DB errors and cache userID on session

2026-02-20 21:06:16 +01:00

handlers_items.go

fix(channelserver): handle ignored DB errors and cache userID on session

2026-02-20 21:06:16 +01:00

handlers_kouryou.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_mail_test.go

…

handlers_mail.go

fix(channelserver): validate packet fields before use in handlers

2026-02-19 00:23:04 +01:00

handlers_mercenary_test.go

refactor(mhfpacket): rename 15 Unk fields with identified meanings

2026-02-18 21:48:08 +01:00

handlers_mercenary.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_misc_test.go

…

handlers_misc.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_mutex_test.go

…

handlers_mutex.go

…

handlers_object_test.go

docs: clarify object ID rework descriptions and remove stale comment

2026-02-20 18:42:08 +01:00

handlers_object.go

refactor: extract gametime package, replace fmt.Printf with zap logging

2026-02-17 17:54:51 +01:00

handlers_plate.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_quest_backport_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_quest_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_quest.go

refactor(channelserver): replace magic numbers with named protocol constants

2026-02-20 19:50:28 +01:00

handlers_register_test.go

refactor(channelserver): replace init() handler registration with explicit construction

2026-02-20 18:58:32 +01:00

handlers_register.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_rengoku_integration_test.go

fix(rengoku): prevent Sky Corridor race condition from wiping skill data (#85)

2026-02-18 18:10:34 +01:00

handlers_rengoku_test.go

…

handlers_rengoku.go

refactor(channelserver): replace magic numbers with named protocol constants

2026-02-20 19:50:28 +01:00

handlers_reserve_test.go

…

handlers_reserve.go

…

handlers_reward_test.go

…

handlers_reward.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_savedata_integration_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_scenario.go

docs: add doc.go files and godoc comments to all packages

2026-02-18 21:39:13 +01:00

handlers_seibattle.go

docs: add doc.go files and godoc comments to all packages

2026-02-18 21:39:13 +01:00

handlers_semaphore_test.go

…

handlers_semaphore.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_session.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_shop_gacha_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

handlers_shop.go

fix(channelserver): handle ignored DB errors and cache userID on session

2026-02-20 21:06:16 +01:00

handlers_simple_test.go

…

handlers_stage_test.go

…

handlers_stage.go

fix(stage): return valid response for empty stage binary requests

2026-02-18 23:02:44 +01:00

handlers_table.go

refactor(channelserver): replace init() handler registration with explicit construction

2026-02-20 18:58:32 +01:00

handlers_tactics_test.go

…

handlers_tactics.go

…

handlers_test.go

refactor(channelserver): replace init() handler registration with explicit construction

2026-02-20 18:58:32 +01:00

handlers_tournament_test.go

refactor(mhfpacket): rename 15 Unk fields with identified meanings

2026-02-18 21:48:08 +01:00

handlers_tournament.go

refactor(mhfpacket): rename 15 Unk fields with identified meanings

2026-02-18 21:48:08 +01:00

handlers_tower_test.go

refactor(mhfpacket): rename 15 Unk fields with identified meanings

2026-02-18 21:48:08 +01:00

handlers_tower.go

fix(channelserver): handle ignored DB errors and cache userID on session

2026-02-20 21:06:16 +01:00

handlers_users_test.go

perf(channelserver): move UserBinary and minidata to memory-only

2026-02-19 00:05:20 +01:00

handlers_users.go

perf(channelserver): move UserBinary and minidata to memory-only

2026-02-19 00:05:20 +01:00

handlers_util_test.go

…

integration_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

model_character.go

refactor(channelserver): replace magic numbers with named protocol constants

2026-02-20 19:50:28 +01:00

raviente.go

docs: add doc.go files and godoc comments to all packages

2026-02-18 21:39:13 +01:00

savedata_lifecycle_monitoring_test.go

fix: resolve all remaining lint errors (errcheck) across 49 files

2026-02-17 18:07:38 +01:00

session_lifecycle_integration_test.go

refactor(config): eliminate ErupeConfig global variable

2026-02-20 17:07:42 +01:00

sys_channel_server_test.go

…

sys_channel_server.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

sys_language_test.go

…

sys_language.go

…

sys_object_test.go

…

sys_semaphore_test.go

…

sys_semaphore.go

fix: re-enable CI lint job and fix ~65 lint errors (partial)

2026-02-17 17:59:00 +01:00

sys_session_test.go

…

sys_session.go

fix(channelserver): handle ignored DB errors and cache userID on session

2026-02-20 21:06:16 +01:00

sys_stage_test.go

…

sys_stage.go

fix: resolve all remaining lint errors (errcheck) across 49 files

2026-02-17 18:07:38 +01:00

sys_time.go

docs: add doc.go files and godoc comments to all packages

2026-02-18 21:39:13 +01:00

test_helpers_test.go

refactor(channelserver): replace init() handler registration with explicit construction

2026-02-20 18:58:32 +01:00

testhelpers_db.go

fix: check all Close() return values for errcheck lint

2026-02-17 23:57:14 +01:00