Houmgaor 8b2667f7a0 fix(handlers): harden gacha_items and boost time limit ACK paths ...

Both bugs surfaced when running protbot against a live Erupe instance.

LoadColumnWithDefault now treats an empty bytea ('\x', len 0) the same
as NULL. The postgres driver returns a non-nil empty slice for empty
bytea, so the prior `data == nil` check let a zero-byte slice reach
handleMsgMhfReceiveGachaItem, which forwarded it to the client as a
malformed gacha_items response. The MHF client interprets a zero-byte
count field as a protocol error and crashes the gacha menu, matching
the #175 symptom class. The handler also gains a defensive fallback
for len(data) == 0 in case another caller hits the same edge.

handleMsgMhfGetBoostTimeLimit was sending two ACKs for a single
request: doAckBufSucceed with the real payload, then an unconditional
doAckSimpleSucceed on the same ack handle. The second ACK was dead on
arrival (the handle was already consumed) but is a latent protocol
bug. Drop it and update the regression test that was asserting the
buggy 2-packet behavior.

2026-04-06 18:04:10 +02:00

..

compression

feat(savedata): add tier 1 data integrity protections

2026-03-17 19:03:43 +01:00

channel_isolation_test.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

channel_registry_local.go

fix(channelserver): correct session handler retail mismatches (#167)

2026-02-27 17:29:32 +01:00

channel_registry_test.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

channel_registry.go

fix(channelserver): correct session handler retail mismatches (#167)

2026-02-27 17:29:32 +01:00

char_save_locks.go

feat(savedata): add tier 2 integrity protections

2026-03-17 19:21:55 +01:00

client_connection_simulation_test.go

test(channelserver): replace time.Sleep with polling loops

2026-03-23 10:57:01 +01:00

constants_quest.go

refactor(channelserver): replace magic numbers with named protocol constants

2026-02-20 19:50:28 +01:00

constants_raviente.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

constants_time.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

doc.go

docs: expand doc.go for channelserver and mhfpacket packages

2026-02-23 18:09:08 +01:00

guild_model.go

…

handlers_achievement_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_achievement.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_bbs_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_bbs.go

No database

2024-03-15 00:54:18 +00:00

handlers_cafe_test.go

fix(handlers): harden gacha_items and boost time limit ACK paths

2026-04-06 18:04:10 +02:00

handlers_cafe.go

fix(handlers): harden gacha_items and boost time limit ACK paths

2026-04-06 18:04:10 +02:00

handlers_campaign_test.go

…

handlers_campaign.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_caravan_test.go

…

handlers_caravan.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_cast_binary_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_cast_binary.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_character_test.go

feat(config): add DisableSaveIntegrityCheck flag for save transfers

2026-03-21 19:38:16 +01:00

handlers_character.go

fix(savedata): add recovery hint to integrity check failure log

2026-03-23 10:15:25 +01:00

handlers_clients_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_clients.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_commands_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_commands.go

…

handlers_data_extended_test.go

style: run gofmt across entire codebase

2026-02-23 21:28:30 +01:00

handlers_data_paper_tables.go

refactor(channelserver): move paper data tables out of handler function

2026-02-23 18:24:54 +01:00

handlers_data_paper_test.go

…

handlers_data_paper.go

…

handlers_data_test.go

feat(savedata): add tier 2 integrity protections

2026-03-17 19:21:55 +01:00

handlers_data.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_discord_test.go

…

handlers_discord.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_distitem_test.go

test(channelserver): add unit tests for helpers, kouryou, scenario, seibattle, and distitem handlers

2026-02-22 18:55:31 +01:00

handlers_distitem.go

…

handlers_diva_test.go

feat(diva): implement Diva Defense point accumulation (#168)

2026-03-18 12:09:44 +01:00

handlers_diva.go

feat(diva): implement Diva Defense point accumulation (#168)

2026-03-18 12:09:44 +01:00

handlers_event_test.go

test(handlers): regression tests for DisableBoostTime/DisableLoginBoost (#187)

2026-04-06 16:22:23 +02:00

handlers_event.go

fix(handlers): honor DisableLoginBoost and DisableBoostTime fully (#187)

2026-04-06 16:16:05 +02:00

handlers_festa_test.go

…

handlers_festa.go

fix(festa): filter trials and rewards for Forward.5 compatibility (#156)

2026-03-18 23:19:25 +01:00

handlers_gacha_test.go

fix(gacha): validate reward pool before charging currency (#175)

2026-03-10 11:28:11 +01:00

handlers_gacha.go

fix(handlers): harden gacha_items and boost time limit ACK paths

2026-04-06 18:04:10 +02:00

handlers_goocoo_test.go

…

handlers_goocoo.go

…

handlers_guild_adventure_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

handlers_guild_adventure.go

fix(handlers): add error handling for swallowed repo/service errors

2026-02-24 13:55:49 +01:00

handlers_guild_alliance_test.go

fix(channelserver): post-RC1 stabilization sprint

2026-03-05 16:39:15 +01:00

handlers_guild_alliance.go

fix(guild): add nil guards for alliance guild lookups (#171)

2026-03-02 19:43:11 +01:00

handlers_guild_board_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_guild_board.go

fix(channelserver): handle silently discarded errors across handlers

2026-02-27 11:33:25 +01:00

handlers_guild_cooking_test.go

…

handlers_guild_cooking.go

fix(channelserver): handle silently discarded errors across handlers

2026-02-27 11:33:25 +01:00

handlers_guild_icon_test.go

test: import 38 channelserver test files from v9.2.x-stable

2026-02-16 22:19:44 +01:00

handlers_guild_info_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

handlers_guild_info.go

fix(guild): add nil guards for alliance guild lookups (#171)

2026-03-02 19:43:11 +01:00

handlers_guild_member_test.go

test: import 38 channelserver test files from v9.2.x-stable

2026-02-16 22:19:44 +01:00

handlers_guild_member.go

…

handlers_guild_mission_test.go

…

handlers_guild_mission.go

…

handlers_guild_ops_test.go

…

handlers_guild_ops.go

fix(guild): fix nil panics causing clan menu softlock (#171)

2026-03-06 00:15:53 +01:00

handlers_guild_scout_test.go

feat: add SQLite support, setup wizard enhancements, and live dashboard

2026-03-05 18:00:30 +01:00

handlers_guild_scout.go

fix(guild): add nil guards in cancel and answer scout handlers

2026-03-03 18:04:33 +01:00

handlers_guild_test.go

…

handlers_guild_tresure_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_guild_tresure.go

refactor(channelserver): migrate remaining guild SQL into GuildRepository

2026-02-20 22:14:48 +01:00

handlers_guild.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_helpers_test.go

…

handlers_helpers.go

refactor(channelserver): extract UserRepository for users table access

2026-02-20 22:18:46 +01:00

handlers_house_test.go

test(channelserver): add handler coverage tests for scout, house, items, rengoku, tower

2026-02-27 11:33:13 +01:00

handlers_house.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_items_tables.go

refactor(items): extract inline data tables from handleMsgMhfEnumeratePrice

2026-02-24 15:34:51 +01:00

handlers_items_test.go

fix(items): stop G-rank Workshop/Cog softlock on missing ACK

2026-03-19 14:35:38 +01:00

handlers_items.go

fix(items): stop G-rank Workshop/Cog softlock on missing ACK

2026-03-19 14:35:38 +01:00

handlers_kouryou_test.go

…

handlers_kouryou.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_mail_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

handlers_mail.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

handlers_mercenary_test.go

…

handlers_mercenary.go

…

handlers_misc_test.go

fix(handlers): fix softlock on forge purchases and N-points

2026-03-23 22:20:32 +01:00

handlers_misc.go

fix(handlers): fix softlock on forge purchases and N-points

2026-03-23 22:20:32 +01:00

handlers_mutex_test.go

…

handlers_mutex.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_object_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_object.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_plate_test.go

test(channelserver): add handler tests for session, gacha, shop, and plate

2026-02-22 16:05:25 +01:00

handlers_plate.go

feat(savedata): add tier 1 data integrity protections

2026-03-17 19:03:43 +01:00

handlers_quest_backport_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_quest_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_quest.go

fix(handlers): correct quest tune-value multiplier handling

2026-04-06 16:45:56 +02:00

handlers_register_test.go

…

handlers_register.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_rengoku_integration_test.go

test(channelserver): replace time.Sleep with polling loops

2026-03-23 10:57:01 +01:00

handlers_rengoku_test.go

…

handlers_rengoku.go

…

handlers_reserve_test.go

test: import 38 channelserver test files from v9.2.x-stable

2026-02-16 22:19:44 +01:00

handlers_reserve.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_reward_test.go

…

handlers_reward.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_savedata_integration_test.go

test(channelserver): replace time.Sleep with polling loops

2026-03-23 10:57:01 +01:00

handlers_scenario_test.go

test(channelserver): add unit tests for helpers, kouryou, scenario, seibattle, and distitem handlers

2026-02-22 18:55:31 +01:00

handlers_scenario.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_seibattle_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_seibattle.go

docs: add doc.go files and godoc comments to all packages

2026-02-18 21:39:13 +01:00

handlers_semaphore_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_semaphore.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_session_test.go

fix(handlers): fix softlock on forge purchases and N-points

2026-03-23 22:20:32 +01:00

handlers_session.go

fix(handlers): fix softlock on forge purchases and N-points

2026-03-23 22:20:32 +01:00

handlers_shop_gacha_test.go

…

handlers_shop_test.go

…

handlers_shop.go

docs(gacha): clarify G1-GG vs ZZ configuration to prevent client crashes (#175)

2026-03-17 19:11:59 +01:00

handlers_simple_test.go

fix(handlers): fix softlock on forge purchases and N-points

2026-03-23 22:20:32 +01:00

handlers_stage_test.go

…

handlers_stage.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_table_test.go

…

handlers_table.go

…

handlers_tactics_test.go

refactor(channelserver): consolidate tests into matching source test files

2026-02-26 23:41:44 +01:00

handlers_tactics.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_test.go

refactor(channelserver): replace init() handler registration with explicit construction

2026-02-20 18:58:32 +01:00

handlers_tournament_test.go

…

handlers_tournament.go

refactor(mhfpacket): rename 15 Unk fields with identified meanings

2026-02-18 21:48:08 +01:00

handlers_tower_test.go

test(channelserver): add handler coverage tests for scout, house, items, rengoku, tower

2026-02-27 11:33:13 +01:00

handlers_tower.go

…

handlers_users_test.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00

handlers_users.go

docs(stubs): annotate empty handlers and add unimplemented reference doc

2026-03-19 10:57:09 +01:00

handlers_util_test.go

test: import 38 channelserver test files from v9.2.x-stable

2026-02-16 22:19:44 +01:00

integration_test.go

test(channelserver): reduce polling interval from 10ms to 1ms

2026-03-23 11:06:50 +01:00

minidata_store_test.go

…

minidata_store.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00

model_character.go

fix(savedata): write playtime back to binary blob on save

2026-03-23 22:00:06 +01:00

quest_cache_test.go

…

quest_cache.go

…

raviente.go

…

repo_achievement_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_achievement.go

fix(achievement): fix test failures from migration 0008 side effects

2026-03-18 12:14:31 +01:00

repo_cafe_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_cafe.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_character_test.go

fix(handlers): harden gacha_items and boost time limit ACK paths

2026-04-06 18:04:10 +02:00

repo_character.go

fix(handlers): harden gacha_items and boost time limit ACK paths

2026-04-06 18:04:10 +02:00

repo_distribution_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_distribution.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_diva_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_diva.go

feat(diva): implement Diva Defense point accumulation (#168)

2026-03-18 12:09:44 +01:00

repo_event_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_event.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_festa_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_festa.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_gacha_test.go

fix(gacha): log and skip gacha_items rows that fail to scan

2026-04-06 17:48:12 +02:00

repo_gacha.go

fix(gacha): log and skip gacha_items rows that fail to scan

2026-04-06 17:48:12 +02:00

repo_goocoo_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_goocoo.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_guild_adventure.go

refactor(channelserver): split repo_guild.go into domain-focused files

2026-02-22 16:42:03 +01:00

repo_guild_alliance.go

…

repo_guild_cooking.go

…

repo_guild_hunt.go

refactor(channelserver): split repo_guild.go into domain-focused files

2026-02-22 16:42:03 +01:00

repo_guild_posts.go

refactor(channelserver): split repo_guild.go into domain-focused files

2026-02-22 16:42:03 +01:00

repo_guild_rp.go

…

repo_guild_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_guild.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_house_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_house.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_interfaces.go

feat(diva): implement Diva Defense point accumulation (#168)

2026-03-18 12:09:44 +01:00

repo_mail_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_mail.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_mercenary_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_mercenary.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_misc_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_misc.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_mocks_test.go

feat(config): add DisableSaveIntegrityCheck flag for save transfers

2026-03-21 19:38:16 +01:00

repo_rengoku_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_rengoku.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_scenario_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_scenario.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_session_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_session.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_shop_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_shop.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_stamp_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_stamp.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_tower_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_tower.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_user_test.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

repo_user.go

revert: remove SQLite support

2026-03-05 23:05:55 +01:00

savedata_lifecycle_monitoring_test.go

test(channelserver): replace time.Sleep with polling loops

2026-03-23 10:57:01 +01:00

session_lifecycle_integration_test.go

fix(gacha): log and skip gacha_items rows that fail to scan

2026-04-06 17:48:12 +02:00

svc_achievement_test.go

feat(achievement): add rank-up notifications (#165)

2026-03-18 11:35:31 +01:00

svc_achievement.go

feat(achievement): add rank-up notifications (#165)

2026-03-18 11:35:31 +01:00

svc_festa_test.go

…

svc_festa.go

fix(channelserver): handle silently discarded errors across handlers

2026-02-27 11:33:25 +01:00

svc_gacha_test.go

fix(gacha): validate reward pool before charging currency (#175)

2026-03-10 11:28:11 +01:00

svc_gacha.go

fix(gacha): validate reward pool before charging currency (#175)

2026-03-10 11:28:11 +01:00

svc_guild_test.go

refactor(test): consolidate two GuildRepo mocks into one

2026-02-24 14:13:20 +01:00

svc_guild.go

refactor(mail): extract mail logic into MailService

2026-02-24 00:05:56 +01:00

svc_mail_test.go

…

svc_mail.go

…

svc_tower_test.go

refactor(tower): extract tower logic into TowerService

2026-02-24 16:07:37 +01:00

svc_tower.go

refactor(tower): extract tower logic into TowerService

2026-02-24 16:07:37 +01:00

sys_capture.go

feat(pcap): complete replay system with filtering, metadata, and live replay

2026-02-23 19:34:30 +01:00

sys_channel_server_test.go

test(channelserver): reduce polling interval from 10ms to 1ms

2026-03-23 11:06:50 +01:00

sys_channel_server.go

fix(gacha): log and skip gacha_items rows that fail to scan

2026-04-06 17:48:12 +02:00

sys_language_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

sys_language.go

…

sys_object_test.go

…

sys_semaphore_test.go

…

sys_semaphore.go

fix: re-enable CI lint job and fix ~65 lint errors (partial)

2026-02-17 17:59:00 +01:00

sys_session_test.go

test(channelserver): reduce polling interval from 10ms to 1ms

2026-03-23 11:06:50 +01:00

sys_session.go

fix(guild): fix nil panics causing clan menu softlock (#171)

2026-03-06 00:15:53 +01:00

sys_stage_test.go

…

sys_stage.go

…

sys_time_test.go

…

sys_time.go

…

test_helpers_test.go

…

testhelpers_db.go

fix(gacha): log and skip gacha_items rows that fail to scan

2026-04-06 17:48:12 +02:00

user_binary_store_test.go

…

user_binary_store.go

…