Commit Graph

46 Commits

Author SHA1 Message Date
Houmgaor
c64dabc3ba fix: check all Close() return values for errcheck lint
Add explicit error discards (_ =) for Close() calls on network
connections, SQL rows, and file handles across 28 files. Also add
.golangci.yml with standard linter defaults to match CI configuration.
2026-02-17 23:57:14 +01:00
Houmgaor
47f7a1f636 fix(channelserver): handle bare Exec errors and filter expected ErrNoRows
138 bare db.Exec calls across 22 handler files silently dropped write
errors. Each is now wrapped with error check and zap logging.

4 QueryRow sites that legitimately return sql.ErrNoRows during normal
operation (new player mezfes, festa rankings, empty guild item box)
now filter it out to reduce log noise.
2026-02-17 23:33:44 +01:00
Houmgaor
46bbb6adf9 fix: resolve all remaining lint errors (errcheck) across 49 files
Fix unchecked error returns on bf.Seek(), db.Exec(), QueryRow().Scan(),
pkt.Build(), logger.Sync(), and binary.Write() calls. The linter now
passes with 0 errors, build compiles, and all tests pass with -race.
2026-02-17 18:07:38 +01:00
Houmgaor
fb3e86f429 fix: handle Query/QueryRow/transaction errors in channel server handlers
Add error checking and logging for ~25 database call sites that were
silently dropping errors, preventing resource leaks (unclosed rows),
nil pointer panics, and silent data corruption in festa transactions.
2026-02-17 17:44:35 +01:00
Houmgaor
afc554f1ec fix(save): avoid double-save.
feat(logging): more complete logging data.
2025-11-01 00:37:59 +01:00
Houmgaor
fc6e479df9 fix(lint): fixing more complex formatters problems. 2025-10-19 22:46:21 +02:00
Houmgaor
8a92a7957e fix(crashes): trying to investigate the causes of crash.
New unit tests to that end.
2025-10-19 19:02:29 +02:00
wish
717d785342 fix possible warehouse error 2024-07-23 21:56:01 +10:00
wish
f5c772413e rename instances of HRP to HR 2024-02-25 22:20:12 +11:00
wish
c74ce4b07f simplify reused code 2024-02-25 14:22:21 +11:00
wish
a9b9c94347 fix RNG 2024-02-21 03:46:15 +11:00
wish
e80a03dcc7 fix Warehouse Item functions 2024-02-21 02:09:26 +11:00
wish
020f122bb0 use better RNG for Warehouse IDs 2024-02-21 02:08:59 +11:00
wish
caf4deb1a6 fix Warehouse Equipment dereference 2024-02-20 21:16:31 +11:00
wish
345126ffcb fix warehouseGetEquipment 2023-12-13 11:50:29 +11:00
wish
7e34862e25 Merge remote-tracking branch 'origin/main' into feature/warehouse-v2
# Conflicts:
#	server/channelserver/handlers.go
2023-12-13 11:38:05 +11:00
wish
7717f2f12a fix Enumerate/UpdateGuacot 2023-12-04 22:06:43 +11:00
wish
4a962e2701 fix SaveDecoMyset on first save 2023-11-29 23:14:34 +11:00
wish
2502b47077 simplify SaveDecoMyset 2023-11-28 22:25:36 +11:00
wish
2199e07be8 simplify SaveDecoMyset 2023-11-28 22:07:20 +11:00
wish
bc12f4cd3b fix DecoMyset responses in legacy versions 2023-11-27 21:03:26 +11:00
wish
fc57d63689 update parsing of many packets 2023-11-19 00:35:22 +11:00
wish
b526608f4b fix titles not updating correctly 2023-10-30 23:37:07 +11:00
wish
aa98e89d77 cover more versions with Hiden savedata 2023-10-02 01:19:56 +11:00
wish
1e1790eb84 fix incorrect case for EnumerateHouse response 2023-10-01 23:17:07 +11:00
wish
a9f280a2ef initial warehouse-v2 concept commit 2023-10-01 03:17:51 +11:00
Samboge
2027238250 Fix for Festa Rewards and House Visit MHF-F5
Partial Fix for Forward 5
2023-09-27 07:12:27 +07:00
wish
e4efb55a03 fix LoadDecoMyset response for G8 and G9 2023-08-31 00:08:03 +10:00
wish
60e86c74fe mitigate LoadDecoMyset crashing on older versions 2023-07-08 00:34:11 +10:00
wish
29d62634fa clean up various save handlers 2023-01-29 22:32:52 +11:00
wish
068b7ba72d clean up various save handlers 2023-01-29 21:35:01 +11:00
wish
88815c0a05 dump other savedata types 2022-09-05 15:42:16 +10:00
wish
b172168418 implement proper house entry verification 2022-09-05 15:26:57 +10:00
wish
670f8f7882 update schema to merge existing data, move trophy 2022-09-04 18:12:51 +10:00
wish
377bb39be6 fix house password checking 2022-09-04 17:45:05 +10:00
wish
9259476316 implement persistent house data 2022-09-04 15:53:24 +10:00
wish
2a1ce2b79d match houses by wildcard name 2022-08-19 17:06:15 +10:00
wish
8a3daa1cfa add exchanged tkts to warehouse gift box 2022-08-19 14:42:00 +10:00
wish
bc75902da1 prevent nil warehouse error 2022-08-16 01:39:53 +10:00
wish
81e40b988d warehouse equipment updates 2022-08-15 21:53:00 +10:00
wish
b7d41c1c7f warehouse item updates 2022-08-15 20:09:19 +10:00
wish
86cb254d1a initial warehouse concept 2022-08-15 15:12:50 +10:00
wish
a0dbe9d8c6 change title db syntax 2022-08-11 18:47:50 +10:00
wish
9fe1b1d04a initial titles implementation 2022-08-11 02:50:59 +10:00
wish
33d28904d1 fix stubbed title enumeration 2022-08-02 18:55:19 +10:00
wish
2c0e7a5267 repository cleanup 2022-07-29 03:25:23 +10:00