Houmgaor 53b5bb3b96 refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API ...

main.go always sets both Channels and Registry together, making the
Channels fallback paths dead code. This removes:

- Server.Channels field from the Server struct
- 3 if/else fallback blocks in handlers_session.go (replaced with
  Registry.FindChannelForStage, SearchSessions, SearchStages)
- 1 if/else fallback block in handlers_guild_ops.go (replaced with
  Registry.NotifyMailToCharID)
- 3 method fallbacks in sys_channel_server.go (WorldcastMHF,
  FindSessionByCharID, DisconnectUser now delegate directly)

Updates anti-patterns.md #6 to "accepted design" — Session struct is
appropriate for this game server's handler pattern, and cross-channel
coupling is now fully routed through the ChannelRegistry interface.

2026-02-22 16:16:44 +01:00

..

compression

…

channel_isolation_test.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

channel_registry_local.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

channel_registry_test.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

channel_registry.go

…

client_connection_simulation_test.go

fix(channelserver): fix flaky integration tests from 3 isolation issues

2026-02-21 00:28:27 +01:00

constants_quest.go

…

constants_raviente.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

constants_time.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

doc.go

…

guild_model.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_achievement_test.go

test(channelserver): add mock-based handler unit tests

2026-02-21 14:01:52 +01:00

handlers_achievement.go

refactor(channelserver): extract Event, Achievement, Shop, and Cafe repositories

2026-02-21 13:13:55 +01:00

handlers_bbs_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_bbs.go

…

handlers_cafe_test.go

test(channelserver): add mock-based handler unit tests

2026-02-21 14:01:52 +01:00

handlers_cafe.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_campaign_test.go

…

handlers_campaign.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_caravan_test.go

…

handlers_caravan.go

…

handlers_cast_binary_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_cast_binary.go

refactor(channelserver): extract UserRepository for users table access

2026-02-20 22:18:46 +01:00

handlers_character_test.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

handlers_character.go

refactor(channelserver): move remaining s.server.db calls into repositories

2026-02-21 14:08:01 +01:00

handlers_clients_test.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

handlers_clients.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

handlers_commands.go

refactor(channelserver): move remaining s.server.db calls into repositories

2026-02-21 14:08:01 +01:00

handlers_core_test.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

handlers_coverage2_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_coverage3_test.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

handlers_coverage4_test.go

…

handlers_coverage5_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_coverage_test.go

…

handlers_data_extended_test.go

…

handlers_data_paper_tables.go

…

handlers_data_paper.go

…

handlers_data_test.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00

handlers_data.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00

handlers_discord_test.go

…

handlers_discord.go

refactor(channelserver): extract UserRepository for users table access

2026-02-20 22:18:46 +01:00

handlers_distitem.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_diva_test.go

…

handlers_diva.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_event_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_event.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_festa_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_festa.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_gacha_test.go

test(channelserver): add handler tests for session, gacha, shop, and plate

2026-02-22 16:05:25 +01:00

handlers_gacha.go

fix(channelserver): prevent guild RP rollover race and redundant stepup query

2026-02-21 00:53:10 +01:00

handlers_goocoo_test.go

test(channelserver): add mock-based handler unit tests

2026-02-21 14:01:52 +01:00

handlers_goocoo.go

refactor(channelserver): extract Goocoo, Diva, Misc, Scenario, and Mercenary repositories

2026-02-21 13:27:08 +01:00

handlers_guild_adventure_test.go

test(channelserver): add handler tests for guild info, alliance, cooking, adventure, and treasure

2026-02-21 18:10:19 +01:00

handlers_guild_adventure.go

refactor(channelserver): migrate remaining guild SQL into GuildRepository

2026-02-20 22:14:48 +01:00

handlers_guild_alliance_test.go

test(channelserver): add handler tests for guild info, alliance, cooking, adventure, and treasure

2026-02-21 18:10:19 +01:00

handlers_guild_alliance.go

refactor(channelserver): migrate remaining guild SQL into GuildRepository

2026-02-20 22:14:48 +01:00

handlers_guild_board_test.go

test(channelserver): add handler tests for guild ops, scout, board, and items

2026-02-21 17:58:08 +01:00

handlers_guild_board.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_guild_cooking_test.go

test(channelserver): add handler tests for guild info, alliance, cooking, adventure, and treasure

2026-02-21 18:10:19 +01:00

handlers_guild_cooking.go

feat(guild): persist weekly bonus exceptional user count

2026-02-21 00:42:16 +01:00

handlers_guild_icon_test.go

…

handlers_guild_info_test.go

test(channelserver): add handler tests for guild info, alliance, cooking, adventure, and treasure

2026-02-21 18:10:19 +01:00

handlers_guild_info.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_guild_member_test.go

…

handlers_guild_member.go

refactor(channelserver): extract GuildRepository for guild table access

2026-02-20 22:06:55 +01:00

handlers_guild_mission.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_guild_ops_test.go

test(channelserver): add handler tests for guild ops, scout, board, and items

2026-02-21 17:58:08 +01:00

handlers_guild_ops.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

handlers_guild_scout_test.go

test(channelserver): add handler tests for guild ops, scout, board, and items

2026-02-21 17:58:08 +01:00

handlers_guild_scout.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_guild_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_guild_tresure_test.go

test(channelserver): add handler tests for guild info, alliance, cooking, adventure, and treasure

2026-02-21 18:10:19 +01:00

handlers_guild_tresure.go

refactor(channelserver): migrate remaining guild SQL into GuildRepository

2026-02-20 22:14:48 +01:00

handlers_guild.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_helpers.go

refactor(channelserver): extract UserRepository for users table access

2026-02-20 22:18:46 +01:00

handlers_house_test.go

fix(channelserver): handle silently swallowed DB scan and exec errors

2026-02-21 13:49:25 +01:00

handlers_house.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_items_test.go

test(channelserver): add handler tests for guild ops, scout, board, and items

2026-02-21 17:58:08 +01:00

handlers_items.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_kouryou.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_mail_test.go

test(channelserver): add mock-based handler unit tests

2026-02-21 14:01:52 +01:00

handlers_mail.go

refactor(channelserver): extract RengokuRepository and MailRepository

2026-02-20 23:31:27 +01:00

handlers_mercenary_test.go

…

handlers_mercenary.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_misc_test.go

…

handlers_misc.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_mutex_test.go

…

handlers_mutex.go

…

handlers_object_test.go

…

handlers_object.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00

handlers_plate_test.go

test(channelserver): add handler tests for session, gacha, shop, and plate

2026-02-22 16:05:25 +01:00

handlers_plate.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00

handlers_quest_backport_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_quest_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_quest.go

refactor(channelserver): eliminate *sql.Tx from repository interfaces

2026-02-21 14:56:59 +01:00

handlers_register_test.go

…

handlers_register.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_rengoku_integration_test.go

fix(channelserver): fix flaky integration tests from 3 isolation issues

2026-02-21 00:28:27 +01:00

handlers_rengoku_test.go

…

handlers_rengoku.go

fix(channelserver): add error logging to silently ignored repo calls

2026-02-21 17:37:29 +01:00

handlers_reserve_test.go

…

handlers_reserve.go

…

handlers_reward_test.go

…

handlers_reward.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_savedata_integration_test.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00

handlers_scenario.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_seibattle.go

…

handlers_semaphore_test.go

…

handlers_semaphore.go

refactor(channelserver): add numeric column helpers and extract protocol constants

2026-02-20 21:18:40 +01:00

handlers_session_test.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

handlers_session.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

handlers_shop_gacha_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_shop_test.go

test(channelserver): add handler tests for session, gacha, shop, and plate

2026-02-22 16:05:25 +01:00

handlers_shop.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

handlers_simple_test.go

…

handlers_stage_test.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

handlers_stage.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

handlers_table.go

…

handlers_tactics_test.go

…

handlers_tactics.go

…

handlers_test.go

…

handlers_tournament_test.go

…

handlers_tournament.go

…

handlers_tower_test.go

…

handlers_tower.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

handlers_users_test.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00

handlers_users.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00

handlers_util_test.go

…

integration_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

minidata_store_test.go

test(channelserver): add store tests and document lock ordering

2026-02-21 13:56:46 +01:00

minidata_store.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00

model_character.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

quest_cache_test.go

test(channelserver): add store tests and document lock ordering

2026-02-21 13:56:46 +01:00

quest_cache.go

refactor(channelserver): extract QuestCache from Server struct

2026-02-21 13:35:04 +01:00

raviente.go

…

repo_achievement.go

refactor(channelserver): extract Event, Achievement, Shop, and Cafe repositories

2026-02-21 13:13:55 +01:00

repo_cafe.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

repo_character_test.go

test(channelserver): add store tests for new repository methods

2026-02-21 14:21:32 +01:00

repo_character.go

refactor(channelserver): move remaining s.server.db calls into repositories

2026-02-21 14:08:01 +01:00

repo_distribution.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_diva.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

repo_event_test.go

refactor(channelserver): eliminate *sql.Tx from repository interfaces

2026-02-21 14:56:59 +01:00

repo_event.go

refactor(channelserver): eliminate *sql.Tx from repository interfaces

2026-02-21 14:56:59 +01:00

repo_festa.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_gacha.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_goocoo.go

refactor(channelserver): extract Goocoo, Diva, Misc, Scenario, and Mercenary repositories

2026-02-21 13:27:08 +01:00

repo_guild_test.go

refactor(channelserver): eliminate *sql.Tx from repository interfaces

2026-02-21 14:56:59 +01:00

repo_guild.go

refactor(channelserver): eliminate *sql.Tx from repository interfaces

2026-02-21 14:56:59 +01:00

repo_house.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_interfaces.go

refactor(channelserver): eliminate *sql.Tx from repository interfaces

2026-02-21 14:56:59 +01:00

repo_mail.go

refactor(channelserver): eliminate *sql.Tx from repository interfaces

2026-02-21 14:56:59 +01:00

repo_mercenary.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_misc.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_mocks_test.go

test(channelserver): add handler tests for session, gacha, shop, and plate

2026-02-22 16:05:25 +01:00

repo_rengoku.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

repo_scenario.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_session.go

refactor(channelserver): extract StampRepository, DistributionRepository, and SessionRepository

2026-02-21 00:06:23 +01:00

repo_shop.go

refactor(channelserver): eliminate *sqlx.Rows/*sql.Rows from repository interfaces

2026-02-21 14:16:58 +01:00

repo_stamp.go

refactor(channelserver): extract StampRepository, DistributionRepository, and SessionRepository

2026-02-21 00:06:23 +01:00

repo_tower.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

repo_user_test.go

test(channelserver): add store tests for new repository methods

2026-02-21 14:21:32 +01:00

repo_user.go

refactor(channelserver): move remaining s.server.db calls into repositories

2026-02-21 14:08:01 +01:00

savedata_lifecycle_monitoring_test.go

…

session_lifecycle_integration_test.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

sys_channel_server_test.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

sys_channel_server.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

sys_language_test.go

refactor(config): rename package _config to config with cfg alias

2026-02-21 13:20:15 +01:00

sys_language.go

…

sys_object_test.go

…

sys_semaphore_test.go

…

sys_semaphore.go

…

sys_session_test.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

sys_session.go

perf(channelserver): use package-level map for ignored opcodes

2026-02-21 13:42:33 +01:00

sys_stage_test.go

…

sys_stage.go

refactor(channelserver): replace global stagesLock with sync.Map-backed StageMap

2026-02-22 15:47:21 +01:00

sys_time.go

…

test_helpers_test.go

refactor(channelserver): remove Channels fallbacks, use Registry as sole cross-channel API

2026-02-22 16:16:44 +01:00

testhelpers_db.go

fix(channelserver): resolve all golangci-lint issues and add handler tests

2026-02-21 14:47:25 +01:00

user_binary_store_test.go

test(channelserver): add store tests and document lock ordering

2026-02-21 13:56:46 +01:00

user_binary_store.go

refactor(channelserver): extract UserBinaryStore and MinidataStore

2026-02-21 13:39:44 +01:00